openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[Java] add missing nullable judgement when required property is true

Open fanqiewanzi opened this issue 1 year ago • 0 comments

fix #18516

  • Add judgment for nullable field to the required judgment.
  • Add test for java okhttp-gson template to avoid regressions

Tests: openapi.yaml

openapi: 3.0.3
info:
  title: test
  description: Test API
  version: 1.0.1

paths:
  /test:
    get:
      responses:
        200:
          description: Valid response
          content:
            application/json:
              schema:
                $ref: "#/components/schemas/SomeObject"

components:
  schemas:
    SomeObject:
      type: object
      required: 
        - ids
        - users
        - user
        - role
        - custom
      properties:
        ids:
          type: array
          nullable: true
          items:
            type: integer
        users:
          type: array
          nullable: true
          items:
            type: object
            properties:
              id:
                type: string
        user:
          type: object
          nullable: true
          properties:
            id:
              type: string
        role:
          type: string
          nullable: true
          enum:
            - admin
            - tenant
        custom:
          $ref: "#/components/schemas/customEnum"
    customEnum:
      type: string
      nullable: true
      enum:
        - custom    

run following command to generate: openapi-generator-cli generate -i openapi.yaml -o test -g java

And the code compiled successfully.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

fanqiewanzi avatar Apr 27 '24 16:04 fanqiewanzi