openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[Java] Update Java version in GitHub actions

Open ErkoRisthein opened this issue 1 year ago • 0 comments

The original issues were:

  1. samples/client/petstore/java/resttemplate-jakarta would not build locally using the gradle wrapper, since it was using an outdated version of Gradle
  2. samples/client/petstore/java/resttemplate-jakarta would not build in Github actions since it was using an outdated Java version 8

Solution:

  • Upgrade the Gradle wrapper to 8.7
  • Update the Java version to the currently supported LTS versions 17 and 21 in Github actions
  • Update CircleCI machines to ubuntu-2004:2024.01.1 which use Java 17
  • Use the gradle wrapper for samples-java-client-jdk17 in Github actions to prevent this issue from happening again

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.6.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

ErkoRisthein avatar Apr 26 '24 14:04 ErkoRisthein