openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[typescript-fetch] Remove a cycle in the discriminator dependency graph.

Open jyasskin opened this issue 1 year ago • 0 comments

This is very similar to https://github.com/OpenAPITools/openapi-generator/issues/6140 and came up in https://github.com/GoogleChrome/chromium-dashboard/pull/3819. I haven't reduced a test case from that PR, but I can if the maintainers here want. I did check that this change removes the circular dependency from https://github.com/GoogleChrome/chromium-dashboard/pull/3819, although getting rid of the cycle requires writing the schema in a way that removes the inheritance from the common base class.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04)

jyasskin avatar Apr 25 '24 21:04 jyasskin