openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard
verified publisher icon OpenAPITools

Remove @Valid even for enum types defined in components

Open CREKD127 opened this issue 1 year ago • 7 comments

fixes https://github.com/OpenAPITools/openapi-generator/issues/18430

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

CREKD127 avatar Apr 22 '24 06:04 CREKD127

thanks for the PR. please follow step 3 to update the samples so that CI can verify the change

wing328 avatar Apr 22 '24 07:04 wing328

@wing328 Is this correctly following step3?

CREKD127 avatar Apr 22 '24 08:04 CREKD127

don't think so. let me try to fix it for you later

wing328 avatar Apr 22 '24 08:04 wing328

update: i've filed https://github.com/OpenAPITools/openapi-generator/pull/18453 instead

wing328 avatar Apr 22 '24 09:04 wing328

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @martin-mfg (2023/08)

wing328 avatar May 08 '24 07:05 wing328

link discussion https://github.com/OpenAPITools/openapi-generator/pull/18453/files#r1590468559

CREKD127 avatar May 08 '24 09:05 CREKD127

i've just merged https://github.com/OpenAPITools/openapi-generator/pull/18606 to improve the tests in the jaxrs-spec generator.

can you please merge the latest master into your branch and add a test or 2 in modules/openapi-generator/src/test/resources/3_0/jaxrs-spec/petstore-with-fake-endpoints-models-for-testing.yaml ?

wing328 avatar May 08 '24 09:05 wing328

update: added a test via https://github.com/OpenAPITools/openapi-generator/pull/18664. please have a look to sese if the result looks good to you.

wing328 avatar May 14 '24 04:05 wing328

filed and merged https://github.com/OpenAPITools/openapi-generator/pull/18697 as a follow-up PR

wing328 avatar May 17 '24 09:05 wing328