openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Set REFACTOR_ALLOF_WITH_PROPERTIES_ONLY to true by default

Open wing328 opened this issue 1 year ago • 0 comments

setting REFACTOR_ALLOF_WITH_PROPERTIES_ONLY to true helps reduce escalations we also communicate via those issues that this flag/rule will be set to true by default in the future release

to fallback set it to false

e.g. --openapi-normalizer REFACTOR_ALLOF_WITH_PROPERTIES_ONLY=false in CLI

fyi @OpenAPITools/generator-core-team

PR checklist

  • [ ] Read the contribution guidelines.
  • [ ] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [ ] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

wing328 avatar Mar 27 '24 03:03 wing328