[WIP] Make Schema type retrieval and checks 3.1 compatible
Swagger Parser only populates the Schema's type field for OAS 3.0.X and under. For schemas versioned 3.1.0 and above the type will be populated in the types field instead (reference).
The solution proposed by swagger-parser is to set the System property bind-type which will ensure that the getType() method of the Schema object will perform the same process of extracting the type as the ModelUtils.getSchemaType() function that I've implemented in this MR.
I believe that using the proposed ModelUtils.getSchemaType() function will allow for more flexibility when writing logic for backward compatibility that might require a distinction of the origin of the type field.
This MR makes almost all type checks spec version agnostic which should hopefully resolve a good chunk of edge cases for 3.1.0 generations.
PR checklist
- [x] Read the contribution guidelines.
- [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
- [x] Run the following to build the project and update samples:
(For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./mvnw clean package ./bin/generate-samples.sh ./bin/configs/*.yaml ./bin/utils/export_docs_generators.sh./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed. - [x] File the PR against the correct branch:
master(upcoming 7.1.0 minor release - breaking changes with fallbacks),8.0.x(breaking changes without fallbacks) - [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.
@g-getsov thanks for the PR. Can you please PM me via Slack to discuss this PR when you've time next week?
https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g
@g-getsov fyi I've merged https://github.com/OpenAPITools/openapi-generator/pull/18313 to better handle array schema in 3.1 spec