openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

fix(java): resolve feign ambiguity in ApiErrorDecoder fix(#17842)

Open jijins1 opened this issue 2 years ago • 4 comments

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @martin-mfg

jijins1 avatar Feb 12 '24 08:02 jijins1

Hello, this is my first pr here.

I have two question. My issue is related to feign 13.2.1 (maybe earlier) should I update dependency in the sample ? The integrationTest feign-no-nullable is KO without my contribution. I don't really know how to correct it.

jijins1 avatar Feb 12 '24 08:02 jijins1

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

wing328 avatar Feb 12 '24 11:02 wing328

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

Maybe because i didn't choosemy email on my account. This is better now ?

jijins1 avatar Feb 13 '24 09:02 jijins1

Maybe because i didn't choosemy email on my account. This is better now ?

yes

wing328 avatar Feb 16 '24 06:02 wing328

in the generated pom.xml, replace 12.5 by 13.2.1

ah ok so the issue only occurs with newer version of feign.

wing328 avatar Feb 28 '24 04:02 wing328

FYI. Feign version updated to newer version via https://github.com/OpenAPITools/openapi-generator/pull/17983

wing328 avatar Feb 28 '24 06:02 wing328