openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard
verified publisher icon OpenAPITools

#11737 Add package to bean name in converter.mustache for EnumConverterConfiguration.java

Open Tomschi opened this issue 2 years ago • 4 comments

Add package to bean name in converter.mustache for EnumConverterConfiguration.java to resolve issue #17737

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [ ] Run the following to build the project and update samples: 
    ./mvnw clean package 
./bin/generate-samples.sh ./bin/configs/*.yaml
./bin/utils/export_docs_generators.sh
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [ ] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Tomschi avatar Jan 29 '24 16:01 Tomschi

can you please follow step 3 to update the samples?

wing328 avatar Feb 05 '24 13:02 wing328

cc @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02) @Zomzog (2022/09) @martin-mfg (2023/08)

wing328 avatar Feb 07 '24 05:02 wing328

A test that shows the problem would be great

MelleD avatar Feb 12 '24 08:02 MelleD

Here we have a similar issue with the Configuration names: https://github.com/OpenAPITools/openapi-generator/issues/17847

Also possible is to remove the @Configuration Annotation and we use directly the @Import from spring and then everyone can decide where and when the Config will be loaded.

MelleD avatar Feb 12 '24 14:02 MelleD

A test that shows the problem would be great

I don't think, that there is any useful test. It is the same like the @Bean definition.

Tomschi avatar Feb 23 '24 11:02 Tomschi

Here is an example to reproduce the issue: https://github.com/Tomschi/openapi-generator-issues

Tomschi avatar Jul 02 '24 15:07 Tomschi