openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[BUG] [Java] Add Generated annotations to more classes

Open jo1gi opened this issue 2 years ago • 2 comments

Fixes #17735

Adds Generated annotations to:

  • RFC3339DateFormat
  • ServerConfiguration
  • ServerVariable
  • ApiResponse
  • ClassDiscriminatorMapping in JSON.mustache
  • TypeReference in api.mustache

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Mentions: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @martin-mfg

jo1gi avatar Jan 29 '24 13:01 jo1gi

Thanks for the PR! It mostly looks good to me. But what is the intention behind GenericTypeRef?

martin-mfg avatar Feb 03 '24 11:02 martin-mfg

But what is the intention behind GenericTypeRef?

The inline TypeReference classes are also flagged if they don't have a Generated annotation. Creating a single TypeReference class (GenericTypeRef) was simpler than annotating all inline TypeReference classes.

jo1gi avatar Feb 05 '24 09:02 jo1gi

@jo1gi looks like this break the build: https://github.com/OpenAPITools/openapi-generator/actions/runs/8612824195/job/23602824257

can you please take a look when you've time?

wing328 avatar Apr 09 '24 17:04 wing328

fixed in the latest master but there's another issue with JDK11 as the code now throws exception during runtime.

i've filed https://github.com/OpenAPITools/openapi-generator/pull/18346 to revert back to TypeReference for the time being.

wing328 avatar Apr 10 '24 03:04 wing328