openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[CS] refactor: update github actions

Open Anakael opened this issue 2 years ago • 2 comments

As discussed in: https://github.com/OpenAPITools/openapi-generator/pull/17471#discussion_r1446844543

Here what I come up with: samples-dotnet-standard.yaml -- for .netstandard clients samples-dotnet.yaml -- for .net7+ samples-dotnet6-client-echo-api.yaml -- for client echo api samples-dotnet6-client.yaml -- for .net6 clients and older (but not .netstandard) samples-dotnet6-server.yaml -- for server tests (.net6+ only. Older versions can also be added, but its out of support now)

I've also moved one restsharp net7 client to fit general structure (client/petstore/csharp/**.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh ./bin/configs/*.yaml
    ./bin/utils/export_docs_generators.sh
    
    (For Windows users, please run the script in Git BASH) Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • [x] File the PR against the correct branch: master (upcoming 7.1.0 minor release - breaking changes with fallbacks), 8.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Anakael avatar Jan 21 '24 16:01 Anakael

@mandrean @shibayan @Blackclaws @lucamazzanti @iBicha @devhl-labs

Anakael avatar Jan 21 '24 16:01 Anakael

@wing328 Can we merge it? :)

Anakael avatar Feb 14 '24 22:02 Anakael

thanks for the PR. let's give it a try

wing328 avatar Feb 28 '24 07:02 wing328