openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

update ktor multiplatform serialization issue

Open Marek00Malik opened this issue 3 years ago • 5 comments

update ktor multiplatform serialization issue - OpenAPITools/openapi-generator#14044

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.3.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the [@jimmidyson, @dr4ke616 @karismann @Zomzog @andrewemery @4brunu @yuantao-yin ]

Marek00Malik avatar Nov 16 '22 20:11 Marek00Malik

@Marek00Malik thanks for the PR. Can you please resolve the merge conflicts when you've time?

wing328 avatar Nov 29 '22 06:11 wing328

@wing328 sorry for the delay, I'm on holiday and didn't notice your message.

On the side, I noticed the upgrade of Kotlin to 1.7.21 which is an excellent idea. But I think it could also be a good idea to add this information in the release notes as this requires some action on the consumer side as well. Currently, the website related to the Kotlin client generator is still mentioning Ktor 1.6.8 and there isn't any were any note on what version of Kotlin this generator is compiled in. https://openapi-generator.tech/docs/generators/kotlin

Marek00Malik avatar Dec 07 '22 18:12 Marek00Malik

@wing328 I've pushed the changes on top of the latest master (thus the force push). As a side note, I've identified that the default JSON mappers do not support all date classes at times, for example for OffsetDateTime adapter is not added in all versions of the implementation for Kotlin (this is why the update).

I will raise this as a separate issue and push tests to Ktor implementations and the Jackson/Gson ones. I also found that if we use Unit as a return response, Moshi has problems deserializing this into a Kotlin type.

Marek00Malik avatar Jan 08 '23 12:01 Marek00Malik

Would it be possible to get this merged in?

The milestone is changed at each release :(

ludovicroland avatar Apr 04 '23 08:04 ludovicroland

@Marek00Malik thanks for the PR. Can you please PM me via Slack to discuss this further?

https://join.slack.com/t/openapi-generator/shared_invite/zt-12jxxd7p2-XUeQM~4pzsU9x~eGLQqX2g

Sorry for the delay in reviewing this as there are too many PRs

wing328 avatar Aug 06 '23 15:08 wing328