openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Add Explicite ContentType Header with JSON value to KTOR clients

Open Marek00Malik opened this issue 3 years ago • 1 comments

Fix that addresses the issue discussed in PR nr #12966. Adding missing ContentType header with JSON value.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. [@jimmidyson @dr4ke616 @karismann @Zomzog @andrew-matteson @4brunu @yutaka0m ]

Marek00Malik avatar Oct 07 '22 18:10 Marek00Malik

@wing328 can we merge this PR? We would love to start using Ktor clients within our Ktor projects and not add additional unnecessary dependencies.

Marek00Malik avatar Oct 14 '22 20:10 Marek00Malik

@Marek00Malik can you please take a look at the error in https://github.com/OpenAPITools/openapi-generator/actions/runs/3244612257/jobs/5321013628 ?

wing328 avatar Oct 18 '22 09:10 wing328

@Marek00Malik can you please take a look at the error in https://github.com/OpenAPITools/openapi-generator/actions/runs/3244612257/jobs/5321013628 ?

Hey @wing328. Samples fixed

Marek00Malik avatar Oct 18 '22 14:10 Marek00Malik