openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[FIX][csharp-netcore] fixed anyOf/oneOf generating non-compilable code (null-coalescing operator on enum)

Open Ikelio opened this issue 3 years ago • 3 comments

Fixes #13384

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request. @mandrean @frankyjuang @shibayan @Blackclaws @lucamazzanti

Ikelio avatar Sep 08 '22 13:09 Ikelio

Can we rerun the tests pls ? I can't see a reason for the csharp netcore .mustache changes to create a timeout during typescript tests.

Ikelio avatar Sep 09 '22 22:09 Ikelio

@Ikelio thanks for the PR. Can we add the test spec mentioned in the issue to the csharp test spec so that we've this case covered moving forward?

"schema": {
  "oneOf": [
	{
	"title": "firstEnum",
	"enum": [
		"one",
		"two"
	  ]
	},
	{
	"title": "secondEnum",
	"type": "integer",
	"enum": [
		"0",
		"1"
	]
	}
  ]
}

wing328 avatar Sep 16 '22 09:09 wing328

@wing328 yes, where should I do that ?

Ikelio avatar Sep 20 '22 22:09 Ikelio

can we bump this?

C0DK avatar Jul 21 '23 07:07 C0DK

@Ikelio can you please resolve the merge conflicts when you've time?

wing328 avatar Jul 21 '23 08:07 wing328

@C0DK would you like to sponsor @Ikelio to give this PR a higher priority?

wing328 avatar Aug 11 '23 01:08 wing328

@Ikelio I tested with the latest master and can no longer repeat the issue (code compiles)

Can you please test with v7.0.1 to see if this fix is still needed? Thanks.

wing328 avatar Oct 03 '23 09:10 wing328