openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Add support for style=deepObject with query parameters in the Rust generator

Open dmeijboom opened this issue 3 years ago • 1 comments

CC: @frol @paladinzh @farcaller @richardwhiuk

Add support for query parameters that use style=deepObject. ~It only works for objects so arrays are still not supported.~

Edit: this is no longer the case, arrays do work now :)

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

dmeijboom avatar Sep 08 '22 08:09 dmeijboom

Tested with our setup and works as expected.

dmeijboom avatar Sep 15 '22 07:09 dmeijboom

@dmeijboom thanks for the PR.

Tests passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/258552656

Let's give it a try.

wing328 avatar Dec 06 '22 16:12 wing328