openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[SPRING] Add converters for enums

Open Zomzog opened this issue 3 years ago • 1 comments

We need to add converters because spring doesn't use jackson for path and query params (cf spring-projects/spring-boot#24233 ) This will fix #12874

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (6.1.0) (minor release - breaking changes with fallbacks), 7.0.x (breaking changes without fallbacks)
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Spring committee : @cachescrubber (2022/02) @welshm (2022/02) @MelleD (2022/02) @atextor (2022/02) @manedev79 (2022/02) @javisst (2022/02) @borsch (2022/02) @banlevente (2022/02)

Zomzog avatar Sep 04 '22 21:09 Zomzog

@poulad FYI - might be of interest to you

welshm avatar Sep 07 '22 13:09 welshm

Any chance it can be merged?

Zomzog avatar Oct 25 '22 19:10 Zomzog

Did this fix the issue https://github.com/OpenAPITools/openapi-generator/issues/12874 for only springboot project or non-spring boot (java spring) project as well because I am using a non spring boot project and still facing the issue

sagarsarwe avatar Apr 12 '23 04:04 sagarsarwe