openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

Freeform object support, safe string operations, URL encoding fixes for C-libcurl

Open harlequin-tech opened this issue 3 years ago • 2 comments

  • Implements freeform object support as the json string of the object. Callers manually decode the json to extract the data. (See #5735).
  • Replaces strcpy and strcat with bounded strncpy and strncat for safety.
  • Fixes URL encoding for query parameters so the keys and values can contain special characters.
  • Tested with 327 endpoint model, subset used for query parameter test and free-form objects.

@zhemant @ityuhui @michelealbano updates on behalf of https://moxion.io.

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

harlequin-tech avatar Apr 06 '22 20:04 harlequin-tech

Thank you for your contribution !

Can you resove the merge confict first ?

ityuhui avatar Apr 07 '22 02:04 ityuhui

Hi @harlequin-tech

How is it going ? If the comments are too time consuming to address, can you submit the first part of this PR (freeform object support) in a seperate PR first ? I think it's OK to merge.

ityuhui avatar Apr 28 '22 07:04 ityuhui