openapi-generator icon indicating copy to clipboard operation
openapi-generator copied to clipboard

[Java][Client] Add support for enum-typed discriminator

Open johnlinp opened this issue 4 years ago • 6 comments

Fixes #806

PR checklist

  • [x] Read the contribution guidelines.
  • [x] Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • [x] Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • [x] File the PR against the correct branch: master (5.3.0), 6.0.x
  • [x] If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Java committee members: @bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch Please take your time to check my PR. Thank you.

johnlinp avatar Nov 25 '21 01:11 johnlinp

CircleCI reports that my PR have failed the command mvn --no-snapshot-updates --quiet clean install -Dorg.slf4j.simpleLogger.defaultLogLevel=error. However, I can successfully execute this command on my local machine. Can someone give me some hints about how to fix it? Thank you.

johnlinp avatar Nov 25 '21 04:11 johnlinp

It seems that the problem was caused by the method public boolean isEnumProperty(). When I changed it into public boolean getIsEnumProperty(), the command will successfully execute on CircleCI.

johnlinp avatar Nov 27 '21 03:11 johnlinp

@wing328 Could you please take a look at my PR? Thank you!

johnlinp avatar Nov 30 '21 23:11 johnlinp

Given that the CI is passing completely, and this is resolving a pesky bug with enums, would you mind taking a look @wing328 ? :)

aeneasr avatar May 13 '22 13:05 aeneasr

Any update on this?

CSALS avatar Oct 14 '23 04:10 CSALS

Any updates? :)

elagerho avatar Jun 25 '24 08:06 elagerho

Hello, Any updates on this issue ? I'm facing the exact same one

StrangePingouin avatar Jul 30 '24 14:07 StrangePingouin