TAPI icon indicating copy to clipboard operation
TAPI copied to clipboard

Review comments on TR547 v3.2 draft

Open roshan-joyce-fujitsu opened this issue 1 year ago • 10 comments

Hi @amazzini ,

TR-547-TAPI Reference Implementation Agreement_v3.2-RJcomments.docx

Attaching the file here with review comments because I could not send it as email attachment.

Please note that I had reduce picture resolutions in this file so that I could reduce the size to 25MB. Files larger than 25MB cannot be uploaded, apparently...

roshan-joyce-fujitsu avatar Jul 09 '24 11:07 roshan-joyce-fujitsu

Added my comments at https://github.com/Open-Network-Models-and-Interfaces-ONMI/TAPI-Activities/blob/main/ContributionsForDiscussions/TR-547-TAPI.RIA_v3.2-RJcomments_AM.docx

amazzini avatar Jul 12 '24 09:07 amazzini

Thanks @amazzini .

I have noted another comment in page 242 of the attached file. This is related to termination-state.

TR-547-TAPI.RIA_v3.2-RJcomments_AM_updated.docx

roshan-joyce-fujitsu avatar Jul 18 '24 05:07 roshan-joyce-fujitsu

Hi @roshan-joyce-fujitsu, I will review the comments on the document and make changes where they are clear. If I have any concerns, I will either raise them here or on a call as appropriate.

nigel-r-davis avatar Feb 04 '25 11:02 nigel-r-davis

@bcjohnso99 As @roshan-joyce-fujitsu indicated that there was only one change to do related to this Issue, we should cover this in 2.6.

nigel-r-davis avatar Feb 17 '25 11:02 nigel-r-davis

Agreed to cover in 2.6

nigel-r-davis avatar Feb 18 '25 14:02 nigel-r-davis

termination-state list expanded in draft of TR-547 v3.3.

Ready for review.

nigel-r-davis avatar Mar 01 '25 23:03 nigel-r-davis

Hi @nigel-r-davis , @bcjohnso99

Please see the text highlighted in the description in Table-39. As we are listing all the states, then this highlighted sentence needs to be removed - because it says there are only 2 possible states.

Image

roshan-joyce-fujitsu avatar Mar 12 '25 13:03 roshan-joyce-fujitsu

Thanks for spotting that. I have changed the text highlighted to "Note: Not all values are applicable for this version of the RIA.".

nigel-r-davis avatar Mar 12 '25 14:03 nigel-r-davis

Fix to error has been pushed to fork nigel-r-davis.

nigel-r-davis avatar Mar 13 '25 15:03 nigel-r-davis

@bcjohnso99 I understand that @roshan-joyce-fujitsu may be on PTO. We need a review of the text early tomorrow. Could you review?

nigel-r-davis avatar Mar 14 '25 00:03 nigel-r-davis