MSS icon indicating copy to clipboard operation
MSS copied to clipboard

Fix DeprecationWarning in requests use

Open joernu76 opened this issue 2 years ago • 3 comments

/opt/conda/envs/mss-develop-env/lib/python3.10/site-packages/requests/auth.py:46: DeprecationWarning: Non-string passwords will no longer be supported in Requests 3.0.0. Please convert the object you've passed in (<class 'NoneType'>) to a string or bytes object in the near future to avoid problems. warnings.warn(

joernu76 avatar May 16 '23 18:05 joernu76

Please assign this to me. I could solve this.

ambiguousphoton avatar Jul 27 '23 06:07 ambiguousphoton

@joernu76 I cannot reproduce this issue with the test suite. Where did you see the warning?

matrss avatar Aug 18 '23 12:08 matrss

we need more details and have to recheck when requests is updated

ReimarBauer avatar Feb 15 '24 15:02 ReimarBauer

Please assign this to me. I could solve this.

kumar1035 avatar Oct 28 '24 18:10 kumar1035

The task is about finding where we could have send None and catch that.

ReimarBauer avatar Oct 29 '24 09:10 ReimarBauer

@ReimarBauer @joernu76, Could it be due to the below ? We don't do a check on whether tuple doesn't contain None in it. https://github.com/Open-MSS/MSS/blob/50f6425d78e13f307521ba82164a2fa3f0228eed/docs/samples/automation/retriever.py#L169

I'm not able to verify whether the issue happens here because,

  • I'm not able to run the file, As the loop expects automated_plotting variable to exist, https://github.com/Open-MSS/MSS/blob/50f6425d78e13f307521ba82164a2fa3f0228eed/docs/samples/automation/retriever.py#L142

  • I tried using the config mentioned in the docstring, https://github.com/Open-MSS/MSS/blob/50f6425d78e13f307521ba82164a2fa3f0228eed/docs/samples/automation/retriever.py#L93

  • But now the loop expects the filename "ST25-joern.ftml" to exists.

I don't think this script is used anywhere in the main application as it resides in the docs section but If you think this could be the issue then I would appreciate your help on executing this script ? So that I can verify for sure whether the warning happens here.

TheMightyRaider avatar Jan 18 '25 16:01 TheMightyRaider

reopen when there are more details

ReimarBauer avatar Feb 20 '25 15:02 ReimarBauer