openeo-python-client icon indicating copy to clipboard operation
openeo-python-client copied to clipboard

load_stac: get asset metadata from "item_assets" in collection instead of from items

Open VictorVerhaert opened this issue 1 year ago • 3 comments

Right now asset metadata like band names are loaded from the nested items in a collection. Getting them directly from item_assets could improve performance.

This would also serve as a quick fix for https://github.com/Open-EO/openeo-geopyspark-driver/issues/460

VictorVerhaert avatar Mar 26 '24 14:03 VictorVerhaert

are you referring here to https://github.com/Open-EO/openeo-python-client/blob/59655b8c16f468c751c4381a29e99674f58be344/openeo/metadata.py#L564-L576 in particular or is this about something else?

soxofaan avatar Mar 28 '24 10:03 soxofaan

Yeah initialy we were talking about the python driver, but this turned out to be useless as each items needs to be checked anyway.

@VincentVerelst mentioned that this could however improve performance for the python client for his use case (GFMap?) so this issue was transferred to the python client.

VictorVerhaert avatar Mar 28 '24 10:03 VictorVerhaert

Indeed, in case that the item_asset extension in present in the STAC collection, we can read the band names from there and don't need to iterate over each item in the collection.

VincentVerelst avatar Mar 28 '24 12:03 VincentVerelst

I think this is already covered by #577 (feel free to reopen if not)

soxofaan avatar Jun 26 '24 07:06 soxofaan