react-onsenui icon indicating copy to clipboard operation
react-onsenui copied to clipboard

Redux navigator

Open argelius opened this issue 9 years ago • 6 comments

argelius avatar Aug 05 '16 08:08 argelius

@philolo1 I took a look at the code. The API looks really nice.

Maybe it makes more sense for the argument to RouterUtil.push to be called route instead of `data.

I guess we need to clean up some of the files, especially RouterNavigator.jsx. The code in componentWillRecieveProps look nice and it was a lot less complicated than I thought it would be.

argelius avatar Aug 05 '16 09:08 argelius

I will look at it on wednesday, today i will look at bugs. Probably the most difficult part is not to share to much of the same code for two components that are kind of similiar (navigator vs Routenavigator).

philolo1 avatar Aug 08 '16 22:08 philolo1

@argelius to summarize since I probably will not have time to fully fix everything, this is what needs to be fixed:

  1. Backbutton
  2. Rendering the pages routes if the page the routes are updated, for example if you have two routes A and B and you update to route A, C.

philolo1 avatar Aug 15 '16 02:08 philolo1

Thanks @philolo1 ! I will take a look at these points soon and merge the new Navigator.

argelius avatar Aug 15 '16 07:08 argelius

Very interesting feature! when do you expect release it?

sergioedo avatar Aug 26 '17 12:08 sergioedo

Sorry, that's moved to another repo, and it's fixed :)

https://github.com/OnsenUI/OnsenUI/pull/1741

sergioedo avatar Aug 26 '17 12:08 sergioedo