oneflow icon indicating copy to clipboard operation
oneflow copied to clipboard
verified publisher icon Oneflow-Inc

fix the usage of argument end_factor in LinearLR

Open basicv8vc opened this issue 3 years ago • 4 comments

In LinearLR, when last_step >= total_iters,

lr = base_lr * 1.

to be consistent with pytorch

lr = base_lr * end_factor

related issue https://github.com/Oneflow-Inc/oneflow/issues/8343

basicv8vc avatar Jun 02 '22 02:06 basicv8vc

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Jun 02 '22 02:06 CLAassistant

Thanks for the fix in this pull request, it looks good to me. I will approve it which will be auto-merged to master.

leaves-zwx avatar Sep 07 '22 08:09 leaves-zwx

The CI failed for code not formatted correctly. Can you please run ninja of_format or make of_format for re-formating the code and then push it?

doombeaker avatar Sep 07 '22 08:09 doombeaker

hi @basicv8vc

  • please allow author editing like this
  • or download and apply the formatting patch here and apply locally and push image

jackalcooper avatar Sep 07 '22 08:09 jackalcooper

Thanks for the fix. I will merge it by a new PR https://github.com/Oneflow-Inc/oneflow/pull/9421.

leaves-zwx avatar Nov 14 '22 08:11 leaves-zwx