OneSignal-Android-SDK
OneSignal-Android-SDK copied to clipboard
In-App Message Unit Test Migration
Description
One Line Summary
In-App Message Unit Test Migration
Details
Since its release, the Android User Model SDK has largely included only new tests and is lacking may important Player Model unit tests. Due to the significant updates to User Model, the existing unit tests on Player Model require significant refactoring.
Motivation
Provide a more comprehensive test suite to Android SDK.
Scope
This PR encompasses In-App Message unit tests only.
OPTIONAL - Other
Where possible, I've kept the original test names of the junit tests from Player Model for easier tracking.
Some considerations I'm still working through:
- reconciling conflicting types between between old unit tests and new unit tests
- enabling mockk for more tests
- "weeding out" unnecessary old tests where appropriate
Testing
Unit testing
All tests in InApp MessagesTests.kt pass. Commented tests with "TODO" markers still need to be migrated/implemented.
Affected code checklist
- [ ] Notifications
- [ ] Display
- [ ] Open
- [ ] Push Processing
- [ ] Confirm Deliveries
- [ ] Outcomes
- [ ] Sessions
- [ ] In-App Messaging
- [ ] REST API requests
- [ ] Public API changes
Checklist
Overview
- [ ] I have filled out all REQUIRED sections above
- [ ] PR does one thing
- If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
- [ ] Any Public API changes are explained in the PR details and conform to existing APIs
Testing
- [ ] I have included test coverage for these changes, or explained why they are not needed
- [ ] All automated tests pass, or I explained why that is not possible
- [ ] I have personally tested this on my device, or explained why that is not possible
Final pass
- [ ] Code is as readable as possible.
- Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
- [ ] I have reviewed this PR myself, ensuring it meets each checklist item
- WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.