fix(core/i18n): optimize i18n text entries
Summary by CodeRabbit
-
Chores
- Expanded the numeric range for address handling to support larger values.
-
Documentation
- Refined the language in wallet security instructions for clarity and improved readability.
Walkthrough
The changes update a numeric range in the PathSchema class by expanding the "address_index" range from "0-1000000" to "0-2147483647". The pull request also improves the wording in comments and translation texts regarding PIN protection instructions, fixing grammatical errors. Additionally, GitHub Actions workflows were updated to use the ubuntu-latest runner instead of fixed Ubuntu versions. No public entities were altered.
Changes
| File(s) | Change Summary |
|---|---|
| core/src/apps/common/paths.py | Expanded "address_index" range in REPLACEMENTS from "0-1000000" to "0-2147483647". |
| core/src/trezor/lvglui/i18n/keys.py, core/src/trezor/lvglui/i18n/locales/en.py | Corrected grammar and improved clarity in PIN protection comments and translation strings. |
| .github/workflows/build-classic.yml, .github/workflows/build-mini.yml, .github/workflows/build-static.yml, .github/workflows/build-touch.yml | Changed GitHub Actions runners from fixed Ubuntu versions (ubuntu-20.04, ubuntu-22.04) to ubuntu-latest. |
[!TIP]
⚡️ Faster reviews with caching
- CodeRabbit now supports caching for code and dependencies, helping speed up reviews. This means quicker feedback, reduced wait times, and a smoother review experience overall. Cached data is encrypted and stored securely. This feature will be automatically enabled for all accounts on May 16th. To opt out, configure
Review - Disable Cacheat either the organization or repository level. If you prefer to disable all data retention across your organization, simply turn off theData Retentionsetting under your Organization Settings.Enjoy the performance boost—your workflow just got faster.
📜 Recent review details
Configuration used: CodeRabbit UI Review profile: ASSERTIVE Plan: Pro (Legacy)
📥 Commits
Reviewing files that changed from the base of the PR and between 58f1f8311603c7411f57c06520c5ca331636268b and 20abdfc4f756e8a48af5dce7a89c9a5e7713165d.
📒 Files selected for processing (7)
-
.github/workflows/build-classic.yml(1 hunks) -
.github/workflows/build-mini.yml(1 hunks) -
.github/workflows/build-static.yml(1 hunks) -
.github/workflows/build-touch.yml(1 hunks) -
core/src/apps/common/paths.py(1 hunks) -
core/src/trezor/lvglui/i18n/keys.py(1 hunks) -
core/src/trezor/lvglui/i18n/locales/en.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (4)
- GitHub Check: Defs check
- GitHub Check: Gen check
- GitHub Check: Style check
- GitHub Check: Analyze (python)
🔇 Additional comments (7)
.github/workflows/build-classic.yml (1)
10-10: Align runner to ubuntu-latest
Switching to the generic runner keeps us on the latest supported Ubuntu and reduces maintenance of fixed versions..github/workflows/build-static.yml (1)
8-8: Use ubuntu-latest for static build
Updating to the latest Ubuntu runner ensures newer tools and security patches without pinning to a specific patch release..github/workflows/build-mini.yml (1)
10-10: Switch mini build to ubuntu-latest
Moving to the latest runner streamlines updates and aligns with other workflows..github/workflows/build-touch.yml (1)
10-10: Update touch build runner to ubuntu-latest
Standardizing on ubuntu-latest across workflows simplifies maintenance and keeps environments current.core/src/apps/common/paths.py (1)
90-90: Appropriate range expansion to match system capabilities.Expanding the address index range from 1 million to the maximum 32-bit signed integer value makes sense. This aligns with the account parameter's range and maximizes the available address space.
core/src/trezor/lvglui/i18n/keys.py (1)
21-24: Grammar and clarity improvements in PIN security instructions.Both corrections fix grammar issues and improve clarity:
- Fixed verb form from "protects" to "protect"
- Changed awkward phrasing to clearer imperative form
- Added proper punctuation and improved word choice
These changes enhance readability without altering functionality.
core/src/trezor/lvglui/i18n/locales/en.py (1)
11-12: Consistent translation improvements align with keys file.The translation text now matches the improved wording in the keys file. These corrections fix grammar errors and improve readability for users. Good consistency across the codebase.
🪧 Tips
Chat
There are 3 ways to chat with CodeRabbit:
- Review comments: Directly reply to a review comment made by CodeRabbit. Example:
-
I pushed a fix in commit <commit_id>, please review it. -
Generate unit testing code for this file. -
Open a follow-up GitHub issue for this discussion.
-
- Files and specific lines of code (under the "Files changed" tab): Tag
@coderabbitaiin a new review comment at the desired location with your query. Examples:-
@coderabbitai generate unit testing code for this file. -
@coderabbitai modularize this function.
-
- PR comments: Tag
@coderabbitaiin a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:-
@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase. -
@coderabbitai read src/utils.ts and generate unit testing code. -
@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format. -
@coderabbitai help me debug CodeRabbit configuration file.
-
Support
Need help? Create a ticket on our support page for assistance with any issues or questions.
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.
CodeRabbit Commands (Invoked using PR comments)
-
@coderabbitai pauseto pause the reviews on a PR. -
@coderabbitai resumeto resume the paused reviews. -
@coderabbitai reviewto trigger an incremental review. This is useful when automatic reviews are disabled for the repository. -
@coderabbitai full reviewto do a full review from scratch and review all the files again. -
@coderabbitai summaryto regenerate the summary of the PR. -
@coderabbitai generate sequence diagramto generate a sequence diagram of the changes in this PR. -
@coderabbitai resolveresolve all the CodeRabbit review comments. -
@coderabbitai configurationto show the current CodeRabbit configuration for the repository. -
@coderabbitai helpto get help.
Other keywords and placeholders
- Add
@coderabbitai ignoreanywhere in the PR description to prevent this PR from being reviewed. - Add
@coderabbitai summaryorSummaryto generate the high-level summary at a specific location in the PR description. - Add
@coderabbitaianywhere in the PR title to generate the title automatically.
CodeRabbit Configuration File (.coderabbit.yaml)
- You can programmatically configure CodeRabbit by adding a
.coderabbit.yamlfile to the root of your repository. - Please see the configuration documentation for more information.
- If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation:
# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json
Documentation and Community
- Visit our Documentation for detailed information on how to use CodeRabbit.
- Join our Discord Community to get help, request features, and share feedback.
- Follow us on X/Twitter for updates and announcements.