onegov-cloud icon indicating copy to clipboard operation
onegov-cloud copied to clipboard

Ogc 1748 foundation 6 translator

Open BreathingFlesh opened this issue 1 year ago • 1 comments

Please fill in the commit message below and work through the checklist. You can delete parts that are not needed, e.g. the optional description, the link to a ticket or irrelevant options of the checklist.

Commit message

Translator Directory: UI to Foundation 6

TYPE: Feature LINK: OGC-1748

Checklist

  • [x] I have performed a self-review of my code
  • [x] I considered adding a reviewer
  • [x] I have tested my code thoroughly by hand

BreathingFlesh avatar Aug 21 '24 10:08 BreathingFlesh

The email addresses are not fully visible in the translator view. It seems disabling overflow-x: auto; would fix it

Tschuppi81 avatar Aug 23 '24 04:08 Tschuppi81

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 89.49%. Comparing base (bdcf6b6) to head (9d4498e). Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...negov/translator_directory/views/usermanagement.py 50.00% 2 Missing :warning:
Additional details and impacted files
Files with missing lines Coverage Δ
src/onegov/org/views/settings.py 81.03% <100.00%> (+0.22%) :arrow_up:
src/onegov/town6/views/usermanagement.py 78.26% <ø> (ø)
src/onegov/translator_directory/app.py 98.52% <100.00%> (ø)
src/onegov/translator_directory/custom.py 100.00% <100.00%> (ø)
src/onegov/translator_directory/layout.py 94.11% <100.00%> (-0.85%) :arrow_down:
src/onegov/translator_directory/request.py 100.00% <100.00%> (ø)
src/onegov/translator_directory/theme/__init__.py 100.00% <100.00%> (ø)
src/onegov/translator_directory/views/language.py 97.56% <100.00%> (+0.33%) :arrow_up:
src/onegov/translator_directory/views/login.py 100.00% <100.00%> (ø)
...rc/onegov/translator_directory/views/translator.py 90.37% <100.00%> (+0.10%) :arrow_up:
... and 1 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bdcf6b6...9d4498e. Read the comment docs.

codecov[bot] avatar Aug 26 '24 07:08 codecov[bot]