onegov-cloud icon indicating copy to clipboard operation
onegov-cloud copied to clipboard

Cleanup/Remove cli cmd and data migration script for agency address f…

Open Tschuppi81 opened this issue 2 years ago • 3 comments

People: Cleanup/Remove cli cmd and data migration script for agency address parsed from portrait field

TYPE: Feature LINK: ogc-1053

Checklist

  • [ ] I have performed a self-review of my code
  • [ ] I considered adding a reviewer
  • [ ] I have added an upgrade hint such as data migration commands to be run
  • [ ] I have updated the PO files
  • [ ] I have added new modules to the docs
  • [ ] I made changes/features for both org and town6
  • [ ] I have updated the election_day API docs
  • [ ] I have tested my code thoroughly by hand
    • [ ] I have tested styling changes/features on different browsers
    • [ ] I have tested javascript changes/features on different browsers
    • [ ] I have tested database upgrades
    • [ ] I have tested sending mails
    • [ ] I have tested building the documentation
  • [ ] I have added tests for my changes/features
    • [ ] I am using freezegun for tests depending on date and times
    • [ ] I considered using browser tests für javascript changes/features
    • [ ] I have added/updated jest tests for d3rendering (election_day, swissvotes)

Tschuppi81 avatar Nov 07 '23 18:11 Tschuppi81

@Daverball is there an easy way to verify if a migration script has been invoked on an instance similar to upgrade tasks in upgrades table? I want to make sure they got executed before removing them...

Tschuppi81 avatar Nov 07 '23 18:11 Tschuppi81

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 89.18%. Comparing base (e0db0be) to head (63d13f7). Report is 9 commits behind head on master.

Additional details and impacted files
Files Coverage Δ
src/onegov/people/cli.py 87.14% <ø> (+17.59%) :arrow_up:

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e0db0be...63d13f7. Read the comment docs.

codecov-commenter avatar Nov 07 '23 18:11 codecov-commenter

@Daverball is there an easy way to verify if a migration script has been invoked on an instance similar to upgrade tasks in upgrades table? I want to make sure they got executed before removing them...

Not unless you explicitly stored something into the database within the migration script that would let you determine that.

Daverball avatar Nov 07 '23 20:11 Daverball