script-lab icon indicating copy to clipboard operation
script-lab copied to clipboard

Issues loading large gists

Open Zlatkovsky opened this issue 7 years ago • 4 comments

Porting this issue from the Script Lab codebase. Almost certainly it applies to us as well: https://github.com/OfficeDev/script-lab-2017/issues/862

Zlatkovsky avatar Aug 25 '18 01:08 Zlatkovsky

@Zlatkovsky just to confirm, the problem here is that there isn't any error indication? Not trying to get that gist to be importable, right?

nico-bellante avatar Aug 25 '18 05:08 nico-bellante

Can we add an effort-level label too?

gergzk avatar Aug 27 '18 18:08 gergzk

@nico-bellante , try this URL: https://gist.github.com/9esuLuciano/9c462c0a0924d4cf4415d385493b5293

You can see that the file at that URL has been truncated. Whereas the "raw" URL still gives us the full data image

So I think the bug is to make sure that if the Gist API returns truncated: true, that we ask for the full URL. See https://developer.github.com/v3/gists/#truncation

Zlatkovsky avatar Aug 27 '18 19:08 Zlatkovsky

Moving to 1.5 as this issue exists in today's Script Lab as well.

nico-bellante avatar Nov 05 '18 23:11 nico-bellante

Fixed.

wandyezj avatar Apr 16 '24 17:04 wandyezj