script-lab icon indicating copy to clipboard operation
script-lab copied to clipboard

Code cleanup: remove solution selectors file-hiding logic

Open Zlatkovsky opened this issue 7 years ago • 1 comments

  // TODO: Nico: REMOVE THIS LOGIC FROM HERE AS IT ISN'T THE RIGHT PLACE TO DO IT
  // https://github.com/OfficeDev/script-lab-react/issues/430
  const { isCustomFunctionsSolution, isDirectScriptExecution } = solutionMetadata.options;
  const files = solutionMetadata.files
    .map(fileId => getFile(state, fileId))
    .filter(file => {
      if (isCustomFunctionsSolution) {
        return [SCRIPT_FILE_NAME, LIBRARIES_FILE_NAME].includes(file.name);
      } else if (isDirectScriptExecution) {
        return file.name === SCRIPT_FILE_NAME;
      } else {
        return true;
      }
    });

Zlatkovsky avatar Dec 03 '18 22:12 Zlatkovsky

@nico-bellante , any idea what this is, and if it's still relevant?

Zlatkovsky avatar Mar 04 '19 20:03 Zlatkovsky

Obsolete.

wandyezj avatar Apr 05 '24 19:04 wandyezj