script-lab-2017 icon indicating copy to clipboard operation
script-lab-2017 copied to clipboard

Content in yaml is wrapped to one line

Open jakobpn opened this issue 8 years ago • 4 comments

The attached file has been produced with "copy to clipboard" in Script Lab.

snippet template.yaml.txt

jakobpn avatar Apr 03 '17 18:04 jakobpn

Hm... truth be told, I actually can't import the snippet.

But I do believe I fixed the issue with commit https://github.com/OfficeDev/script-lab/commit/beae1fa763f6bde03f244b3112b59e9eafa115e7. Could you try it?

Zlatkovsky avatar Apr 06 '17 01:04 Zlatkovsky

Never mind, was able to import, and still having the same issue. Will investigate further.

Zlatkovsky avatar Apr 06 '17 01:04 Zlatkovsky

It doesn't looks like I can fix this without completely changing out our Yaml library to something like https://git.daplie.com/coolaj86/json2yaml. Which might end up being much more destabilizing (or might just fix all our problems for us -- who knows...)

Postponing to v1.2. @jakobpn , removing "blocker", since I think we can live with this in the short-term (or at least, the alternative of trying to switch things out now seems even less appealing...)

Zlatkovsky avatar Apr 07 '17 03:04 Zlatkovsky

Strangely, the fix that worked for the office-js-snippets repo (https://github.com/OfficeDev/office-js-snippets/commit/385d6ea8cdcb177e1f5336dad8323048e6063f88) doesn't seem to make a difference to Script Lab. The good news, though, is that the snippets repo itself takes these snippets and seems to de-single-line them.

The repro in this issue still repro-s, though.

Synced up the files all the same, though: https://github.com/OfficeDev/script-lab/commit/9c372d5686af1fec4f51460cfdf12f2a43a97add

Zlatkovsky avatar Nov 25 '17 01:11 Zlatkovsky