OfficeDev
Fix HttpClientWebRequest so that it supports both GET and POST requests.
Hi @dconnelly, I'm your friendly neighborhood Azure Pull Request Bot (You can call me AZPRBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.azure.com.
TTYL, AZPRBOT;
Current coverage is 10.68%
Merging #461 into master will increase coverage by +0.26% as of
bbab906
@@ master #461 diff @@
======================================
Files 550 550
Stmts 20432 20440 +8
Branches 2625 2628 +3
Methods 0 0
======================================
+ Hit 2131 2183 +52
- Partial 153 157 +4
+ Missed 18148 18100 -48
Review entire Coverage Diff as of
bbab906Powered by Codecov. Updated on successful CI builds.
@dconnelly, Thanks for signing the contribution license agreement so quickly! Actual humans will now validate the agreement and then evaluate the PR.
Thanks, AZPRBOT;
@dconnelly thanks for your contribution. Maybe you can add tests that declares initialization of HttpClientWebRequest to be working with different request methods.
Sure I can add some unit tests.
Also, are there plans for actual integration tests with real accounts? Perhaps Office365 with some test accounts would be a good start, and should improve code coverage numbers considerably.
Yes that would be nice. AFAIK we might ran into troubles while credentials must not be exposed and Microsoft needs to donate some accounts.
Isn't this a Microsoft project? ;-)
Probably all is needed is a few O365 test accounts and Travis does support storing encrypted items in .travis.yml (see http://docs.travis-ci.com/user/encryption-keys/).
maybe @vboctor can check on the integration testing topic and the related accounts. Meanwhile some unit-tests could be added to have this merged ;-)
Hey sorry André been swamped. Will get to it this weekend.
- David
On Wed, Dec 2, 2015 at 1:41 PM, André Behrens [email protected] wrote:
@dconnelly https://github.com/dconnelly are you planning any changes so far?
— Reply to this email directly or view it on GitHub https://github.com/OfficeDev/ews-java-api/pull/461#issuecomment-161442485 .
@dconnelly it would be nice if we could merge your contribution. Please provide the mentioned changes if you are able to.
running into this issue too in my opinion this should just be merged. I verified the fix worked so we are running on master + this change on our production instance
André, I added some unit test coverage although it's difficult to test fully without an actual server connection. Let me know what you think.
@dconnelly once license header has been added this will be merged. Thanks for your contribution.
@serious6 can you tell me the line of text you want added and the file to add it and I will make a commit? madness that this has not been merged for over a year
