Office-Add-in-UX-Design-Patterns-Code icon indicating copy to clipboard operation
Office-Add-in-UX-Design-Patterns-Code copied to clipboard
verified publisher icon OfficeDev

Fixing a error in dismiss function

Open Karma-design opened this issue 9 years ago • 2 comments

"el" may not be defined if the user dismissed the toast manually, so before removing it we must check its existence. Easy to reproduce : close the toast before it's automatically closed, you will see a js error.

Karma-design avatar Nov 30 '16 11:11 Karma-design

@Karma-design - Thank you for your submission! We really appreciate this.

@WrathOfZombies - Can you please review this PR? Thanks!

Reezaali avatar Nov 30 '16 17:11 Reezaali

Sorry for the delay. I'll merge this once we have the new build process so as to keep the contribution history.

WrathOfZombies avatar Feb 15 '17 04:02 WrathOfZombies