OfficeDev
chore: Update dependencies and add Supplier email and phone fields
This commit updates the dependencies in the package.json file of the msgext-northwind-inventory-ts sample. It adds the following dependencies:
- @azure-rest/[email protected]
- @azure/[email protected]
- @azure/[email protected]
- @azure/[email protected]
Additionally, it modifies the model.ts file to include the SupplierEmail and SupplierPhone fields in the ProductEx interface. This allows for storing and retrieving the email and phone information of suppliers.
These changes were made to improve the functionality and data representation of the Northwind Inventory sample.
Thank you for your PR @MilanKaur-01 👏
@BobGerman @rabwill would you be able to review?
@garrytrinder and @BobGerman Is it more logical to keep the ACS sample as a separate sample, rather than merging it with the existing NW bot, which might be a simpler starting point for beginners?
+1 - I think it should be a separate sample - this sample has become popular on its own and though I love ACS I don't want to add the dependencies for the basic scenario...
@MilanKaur-01 do you mind making a new sample here? Like - copy the whole project to a new folder such as "msgext-northwind-inventory-with-acs" and make a new PR? Thanks!
[like] Milan Kaur reacted to your message:
From: Bob German @.> Sent: Friday, May 31, 2024 4:03:39 PM To: OfficeDev/Copilot-for-M365-Plugins-Samples @.> Cc: Milan Kaur @.>; Mention @.> Subject: Re: [OfficeDev/Copilot-for-M365-Plugins-Samples] chore: Update dependencies and add Supplier email and phone fields (PR #117)
+1 - I think it should be a separate sample - this sample has become popular on its own and though I love ACS I don't want to add the dependencies for the basic scenario...
@MilanKaur-01https://github.com/MilanKaur-01 do you mind making a new sample here? Like - copy the whole project to a new folder such as "msgext-northwind-inventory-with-acs" and make a new PR?
— Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/Copilot-for-M365-Plugins-Samples/pull/117#issuecomment-2142560010, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5VES6GGCYPEIIFLKBM6NZDZFCNNXAVCNFSM6AAAAABH6WUHJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNBSGU3DAMBRGA. You are receiving this because you were mentioned.Message ID: @.***>
@MilanKaur-01 I've just merged some maintenance updates for the msgext-northwind-inventory-ts sample which includes updating dependencies to the latest versions.
As suggested in the comments, it is best that we create a new sample which includes the ACS updates. With that in mind, I will close this PR.
Yes will do. Thank you for he nudge.
From: Garry Trinder @.> Sent: Thursday, August 29, 2024 7:29 AM To: OfficeDev/Copilot-for-M365-Samples @.> Cc: Milan Kaur @.>; Mention @.> Subject: Re: [OfficeDev/Copilot-for-M365-Samples] chore: Update dependencies and add Supplier email and phone fields (PR #117)
@MilanKaur-01https://github.com/MilanKaur-01 I've just merged some maintenance updates for the msgext-northwind-inventory-ts sample which includes updating dependencies to the latest versions.
As suggested in the comments, it is best that we create a new sample which includes the ACS updates. With that in mind, I will close this PR.
Reply to this email directly, view it on GitHubhttps://github.com/OfficeDev/Copilot-for-M365-Samples/pull/117#issuecomment-2317878279, or unsubscribehttps://github.com/notifications/unsubscribe-auth/A5VES6GCIRN7ODK5DVPUQMTZT4V35AVCNFSM6AAAAABH6WUHJKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGMJXHA3TQMRXHE. You are receiving this because you were mentioned.Message ID: @.@.>>