cli icon indicating copy to clipboard operation
cli copied to clipboard

Repository not set up correctly for Go major versioning

Open seanamos opened this issue 1 year ago • 1 comments

Since v2, the repository does not work correctly with the Go SDK as it has not been set up correctly to deal with major versions: https://go.dev/doc/modules/major-version

Command to reproduce

➜ go run github.com/OctopusDeploy/cli/cmd/octopus@latest version
1.7.1

➜ go run github.com/OctopusDeploy/cli/cmd/[email protected] version
go: github.com/OctopusDeploy/cli/cmd/[email protected]: github.com/OctopusDeploy/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/OctopusDeploy/cli/v2")

➜ go run github.com/OctopusDeploy/cli/v2/cmd/[email protected] version
go: github.com/OctopusDeploy/cli/v2/cmd/[email protected]: github.com/OctopusDeploy/[email protected]: invalid version: module contains a go.mod file, so module path must match major version ("github.com/OctopusDeploy/cli/v2")

As you can see, whether using go install or go run, there is no way to run a newer version than v1.7.1 as the go module/versioning systems requires v2 in the import paths: github.com/OctopusDeploy/cli/v2

seanamos avatar May 14 '24 21:05 seanamos

Just checking in, has anyone noticed this yet?

I'm happy to push up a PR with the required changes in my downtime.

seanamos avatar Jan 28 '25 14:01 seanamos