ProxyManager icon indicating copy to clipboard operation
ProxyManager copied to clipboard
verified publisher icon Ocramius

Allow PHP 8.1

Open Fredthelead opened this issue 3 years ago • 6 comments

  • Changed the PHP ~8.0.0 constraint to ~8.0
  • Ran composer update with composer 2.3.9 and PHP 8.0.21
  • Added PHP 8.1 to the github pipes
  • Updated psalm config and suppressed a false-positive

Fixes https://github.com/Ocramius/ProxyManager/issues/721

Fredthelead avatar Jul 11 '22 13:07 Fredthelead

Anything that needs to be done in order to get this merged & released? Happy to help if something is missing.

dfreudenberger avatar Jul 22 '22 15:07 dfreudenberger

Release requires this work: https://github.com/Ocramius/ProxyManager/milestone/56

Ocramius avatar Jul 22 '22 16:07 Ocramius

The problem with this PR is that the tests won't work with locked dependencies on both php 8.0 and 8.1. Not sure how to solve this without removing some tests.

Fredthelead avatar Jul 23 '22 09:07 Fredthelead

Supporting 8.0 and 8.1 at the same time might indeed be challenging.

I can suggest skipping some tests on 8.0, so we focus on releasing a version that works on both PHP 8.0 and 8.1, then drop 8.0 support in a new minor, which in turn removes all conditionals that disable some tests.

Ocramius avatar Jul 23 '22 09:07 Ocramius

Hi, any update on this?

jakublabno avatar Oct 31 '22 14:10 jakublabno

https://github.com/Ocramius/ProxyManager/pull/738#issuecomment-1296944093

Ocramius avatar Oct 31 '22 14:10 Ocramius