openrvdas icon indicating copy to clipboard operation
openrvdas copied to clipboard

CSS Update

Open yoLewshi opened this issue 11 months ago • 6 comments

An attempt to improve styling without majorly changing the markup. Won't be offended if you don't like it, equally happy to really tear into things if you want to radically change the UI in some way.

You can play around with the colours used for the variables to try out alternatives if you like.

  • Mostly added a lot of css variables which can be tweaked to change the styling
  • Altered the colours (less grey, more blue)
  • Moved cruise definition and user login elements to make use of the space at the top of the page
  • Removed some hardcoded inline styles and replaced with classes

image

image

yoLewshi avatar Feb 11 '25 22:02 yoLewshi

I really like the idea of moving the login and current/load file elements up to the top, as well as color coding the logged messages on the main console page. Not as wild about the blue vs gray change.

Also: not able to get it to run properly on the test server at http://143.110.155.117/ - I pulled the patch locally, but it's looking like maybe some path or permission needs tweaking:

Screenshot 2025-02-18 at 11 53 08 AM

davidpablocohn avatar Feb 18 '25 00:02 davidpablocohn

I've swapped the blue back to grey:

image

Also changed how it references the css file but I can't get the standard install running locally and I'm about to go to sea so don't want to mess too much with mine. Did you get any sort of browser console error when it failed to load?

yoLewshi avatar Mar 02 '25 23:03 yoLewshi

Thanks! No browser console errors, and yet much of the styling is as borked as before. Very puzzling...

Regardless, no worries - let's put this on hold until you're back. Until then, fair winds and following seas!

davidpablocohn avatar Mar 03 '25 04:03 davidpablocohn

Hi Lewis - checking in: are you back shoreside? I've been pushing a whole bunch of changes (most importantly the Ella-templating) into dev, and would love to push it all to master soon (maybe as v2.0.0?). It would be great to include these style fixes if you've got a minute to look at whatever's going wrong for me...

davidpablocohn avatar Apr 04 '25 17:04 davidpablocohn

Sorry this dropped off my radar, I'll have a go at getting it running with the default installation next week

yoLewshi avatar May 09 '25 04:05 yoLewshi

No worries, and thanks for revisiting!

On Thu, May 8, 2025 at 9:29 PM Lewis Wilkie @.***> wrote:

yoLewshi left a comment (OceanDataTools/openrvdas#421) https://github.com/OceanDataTools/openrvdas/pull/421#issuecomment-2865063505

Sorry this dropped off my radar, I'll have a go at getting it running with the default installation next week

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/421#issuecomment-2865063505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3VVB7TGELR3MZ2Q6N325QVKXAVCNFSM6AAAAABW6GPNFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRVGA3DGNJQGU . You are receiving this because you were assigned.Message ID: @.***>

davidpablocohn avatar May 09 '25 15:05 davidpablocohn

Hmm - I'm still getting an un-styled page, with no apparent js errors. I get the same behavior on MacOS and fresh Ubuntu and Rocky installations:

[image: Screenshot 2025-05-16 at 7.50.49 PM.png]

On Fri, May 9, 2025 at 8:50 AM David Pablo Cohn @.***> wrote:

No worries, and thanks for revisiting!

On Thu, May 8, 2025 at 9:29 PM Lewis Wilkie @.***> wrote:

yoLewshi left a comment (OceanDataTools/openrvdas#421) https://github.com/OceanDataTools/openrvdas/pull/421#issuecomment-2865063505

Sorry this dropped off my radar, I'll have a go at getting it running with the default installation next week

— Reply to this email directly, view it on GitHub https://github.com/OceanDataTools/openrvdas/pull/421#issuecomment-2865063505, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFO7V3VVB7TGELR3MZ2Q6N325QVKXAVCNFSM6AAAAABW6GPNFGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDQNRVGA3DGNJQGU . You are receiving this because you were assigned.Message ID: @.***>

davidpablocohn avatar May 17 '25 03:05 davidpablocohn

Hmm - I'm still getting an un-styled page, with no apparent js errors. I get the same behavior on MacOS and fresh Ubuntu and Rocky installations:

Screenshot 2025-05-16 at 7 50 49 PM

davidpablocohn avatar May 17 '25 03:05 davidpablocohn

To test, I pushed the pr to a new branch on Github and used for fresh installs: pr-421

The Rocky installation is running at http://24.199.122.156/

davidpablocohn avatar May 17 '25 03:05 davidpablocohn

Incorporated into SOI recommendations and merged to dev

davidpablocohn avatar Oct 23 '25 18:10 davidpablocohn