Roassal3

Roassal3 copied to clipboard

I started gradually reviewing the TreeMap package. It seems to me that some points can be made clearer. Here is my first suggestion: rename the method ```Smalltalk RSTreeMapLayout >> prepareShapesForLayout:...

NSUSpray

Roassal3 tests are used each time a user creates a pull request, then the tests should use that specific branch

akevalion

RSComposite>>#adjustToChildren is wrong

6

I got an interesting case where calling twice the `adjustToChildren` made different results and I think the logic of this method is wrong. We have a composite shape and some...

pavel-krivanek

RSDSM should offer a way to easily customize the color of any cell

1

For example a block [:x :y | ... color of cell at X/Y ]

NicolasAnquetil

There is a new lint rule added in https://github.com/pharo-project/pharo/pull/11261/ to simplify code. Roassal could be simplified in RSAbstractLine>>#setAnchor:shape: by using #ifNotNil: 

astares

old code is related to the first version of roassal3

akevalion

RSAthensMorph doesn't draw border according to border style when set

10

Bug description If a border style is set on a RSAthensMorph, the drawOn: method doesn't use it. To Reproduce Steps to reproduce the behavior: Set a border style on a...

StewMacLean

Full Metacello group does not include other groups

6

The "full" Metacello group actually does not load the "Core" group, so it is not really the "Full" version. I suggest that the "Full" Roassal 3 Baseline group includes also...

hernanmd

RSBoundingShape>>computeEncompassingRectangleFor:matrix: removed but still used

6

Apparently : ``RSBoundingShape>>computeEncompassingRectangleFor:matrix:`` has been removed by commit: https://github.com/ObjectProfile/Roassal3/commit/2a9366e690244703251b7f8310152ddf98c772d9#diff-0d926732eee031954909dd744251d64f4e58b548cbaa0328ff4a54317c8fad9c but this still used in: ``RSBoundingShape>>computeEncompassingRectangleFor: rect ^ self computeEncompassingRectangleFor: rect matrix: self matrix``

SergeStinckwich

#reset methods should be in initialization protocol

2

Hi! 👋 - see https://github.com/pharo-project/pharo/issues/2607, which this unblocks. Hope this makes sense. PR incoming!

gypsydave5