java-html-sanitizer icon indicating copy to clipboard operation
java-html-sanitizer copied to clipboard

Proposed fix for issue #223: forbidden character references in sanitized html

Open simon-greatrix opened this issue 5 years ago • 4 comments

simon-greatrix avatar Feb 07 '21 21:02 simon-greatrix

I'll look at this in more detail soon. Thanks so much.

mikesamuel avatar Feb 07 '21 21:02 mikesamuel

When you asked I was like "I would NEVER submit a merge request with failing test!". Then I looked at my IDE and saw that it said "No tests found", because it has forgotten how JUnit 4 works apparently. So, I'll have to change my claim to "I would never KNOWINGLY submit a merge request with failing tests!"

simon-greatrix avatar Feb 07 '21 23:02 simon-greatrix

Heh. Yeah, the codebase has some Java5/6 compatibility baggage.

mikesamuel avatar Feb 07 '21 23:02 mikesamuel

Looks OK now - hope those were the correct changes.

simon-greatrix avatar Feb 08 '21 00:02 simon-greatrix