NodeGoat icon indicating copy to clipboard operation
NodeGoat copied to clipboard

Migration to EJS

Open UlisesGascon opened this issue 6 years ago • 4 comments

Context

  • This is part of release-1.5 #148
  • MEDIUM priority task

Tasks

  • [ ] Remove dependency Swig in package.json
  • [ ] Add dependency ejs in package.json
  • [ ] Configure express to use ejs as template engine
  • [ ] migrate all the files from /app/views/**.html to EJS
  • [ ] Validate the instalation with the local test
  • [ ] Add and submit the changes in package-lock.json
  • [ ] Add the primary depdency list to the readme.md
  • [ ] Check that the npm tasks are working as expected
  • [ ] Update the readme.md with the extra relevant info (if needed)

Assignation

  • This tasks is open for assignation, just claim it (as reply to this) and submit your PR ;-)

Important

UlisesGascon avatar Aug 06 '19 06:08 UlisesGascon

Hi there! I'd like to work on this issue. When do you need this finished?

flippedcoder avatar Aug 16 '19 03:08 flippedcoder

Hi @flippedcoder!

Super welcome aboard. There is no deadline or pressure for this issue, so you can work on it quietly 😄

I just assigned this issue to you. Please send the PR against branch version-1.5 😉.

If you have more questions.. please, ping me ^^

UlisesGascon avatar Aug 16 '19 09:08 UlisesGascon

@UlisesGascon Just a quick update, I've gotten the migration over to ejs finished! I'm going through and fixing all of the errors from npm run precommit. I should have a PR up for this some time next week.

flippedcoder avatar Sep 27 '19 01:09 flippedcoder

Looks like this got closed with #179

flippedcoder avatar Jul 23 '20 22:07 flippedcoder