Nettacker icon indicating copy to clipboard operation
Nettacker copied to clipboard

Refactor the code to make sure os path related logic is OS agnostic

Open arkid15r opened this issue 1 year ago • 26 comments

Refactor the code to make the code expecting Unix/Linux paths OS-independent. Test and ensure that the the entire application with all its functionality (including Scan engine, API and WebUI) works equally fine on both Windows and Unix-like operating systems

arkid15r avatar Oct 01 '24 16:10 arkid15r

Hi, I'd like to work on this issue, could you assign it to me?

winters0x64 avatar Dec 07 '24 17:12 winters0x64

Hi @arkid15r ,

I noticed that issue #933: Refactor the code to make sure os path related logic is OS agnostic #933 is currently assigned but hasn’t had any recent activity in the last two weeks. I’m eager to contribute and would love to help move this forward. If the current assignee is unavailable or needs assistance, I would be happy to take over or collaborate to resolve this issue promptly. Please let me know how I can assist. Looking forward to your response!

bhagyashree980 avatar Dec 19 '24 13:12 bhagyashree980

I'm still working on this, just wanted to make sure everything is working before i send the final PR.

winters0x64 avatar Dec 19 '24 13:12 winters0x64

@winters0x64 Thank you for your update

bhagyashree980 avatar Dec 19 '24 13:12 bhagyashree980

@bhagyashree980 , appreciate you looking into this, I was occupied with implementing some security checks, that's why this got delayed. If you want to contribute you can try to improve the nettacker engine part, I'll be looking at that after this maybe we can collaborate on that.

winters0x64 avatar Dec 19 '24 14:12 winters0x64

Hi @winters0x64 , Thank you for the update and for sharing the context. I understand how implementing security checks can take priority. I appreciate the suggestion to look into improving the Nettacker engine part—I'll start exploring it right away.

bhagyashree980 avatar Dec 19 '24 16:12 bhagyashree980

It's been a month for the previous user,Can I get the chance?

vishakha-mali avatar Jan 29 '25 18:01 vishakha-mali

@vishakha-mali , I appreciate your interest in the issue but I'm still resolving this issue with @arkid15r , my PR is almost complete, just testing all the edge cases that might arise due to cross platform compatibility issues.

winters0x64 avatar Jan 29 '25 18:01 winters0x64

Yeah sure, I thought you were not active.I just wanted to give a try as I am a beginner.

vishakha-mali avatar Jan 29 '25 19:01 vishakha-mali

@vishakha-mali , I encourage you to still try to fix this issue, collective efforts make the project better, you'll also learn a lot. Feel free to ask any doubts if you have I'd be happy to help, all the best :)

winters0x64 avatar Jan 29 '25 19:01 winters0x64

@winters0x64 are you planning to migrate the dockerfile to also work on windows or only the paths? Cause I had tried running this on my windows machine a few days back and with a some changes it works well, so lemme know what you're planning and we can work on this together?

pUrGe12 avatar Feb 03 '25 05:02 pUrGe12

@pUrGe12 I was not planning to migrate the Dockerfile to support windows as well, only going for the paths right now, afaik it'll work on windows machine right now but if it affects upgradeability, as in future the path could become an issue so its better to use the proper paths for the respective OS. Sure we can work on this togethter, hmu.

winters0x64 avatar Feb 05 '25 19:02 winters0x64

As a beginner in open source contribution ,I want to try to resolve this issue and I am working on it

SumraShahzadi avatar Feb 13 '25 07:02 SumraShahzadi

hey @SumraShahzadi I wanted to ask if you were working on this issue or if i could jump on this one?

Manushya-a avatar Mar 17 '25 05:03 Manushya-a

yes ,you can

On Sun, Mar 16, 2025 at 10:12 PM Manav Acharya @.***> wrote:

hey @SumraShahzadi https://github.com/SumraShahzadi I wanted to ask if you were working on this issue or if i could jump on this one?

— Reply to this email directly, view it on GitHub https://github.com/OWASP/Nettacker/issues/933#issuecomment-2728188497, or unsubscribe https://github.com/notifications/unsubscribe-auth/BNRYZBSUHXQXTRW2IJASQVD2UZKVLAVCNFSM6AAAAABPF6UU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRYGE4DQNBZG4 . You are receiving this because you were mentioned.Message ID: @.***> [image: Manushya-a]Manushya-a left a comment (OWASP/Nettacker#933) https://github.com/OWASP/Nettacker/issues/933#issuecomment-2728188497

hey @SumraShahzadi https://github.com/SumraShahzadi I wanted to ask if you were working on this issue or if i could jump on this one?

— Reply to this email directly, view it on GitHub https://github.com/OWASP/Nettacker/issues/933#issuecomment-2728188497, or unsubscribe https://github.com/notifications/unsubscribe-auth/BNRYZBSUHXQXTRW2IJASQVD2UZKVLAVCNFSM6AAAAABPF6UU6OVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDOMRYGE4DQNBZG4 . You are receiving this because you were mentioned.Message ID: @.***>

SumraShahzadi avatar Mar 17 '25 14:03 SumraShahzadi

Hi, I noticed this issue is unassigned, and I would love to contribute to resolving it.
Can I take this up? Please let me know how I can help!

zekeyeager-tech avatar Apr 01 '25 17:04 zekeyeager-tech

@zekeyeager-tech same question to you as to other students keen to get this assigned to them - Do you understand the current architecture and places in the code which created this challenge? Do you use Python on Windows? Do you have experience porting Python code from Linux to Windows ?

securestep9 avatar Apr 01 '25 19:04 securestep9

Hey, I see that there are some PRs open for this issue. Is there any additional work or testing needed that I can help with? I am a beginner and I would like to work on this good first issue!

codeshazard avatar Sep 25 '25 17:09 codeshazard

@codeshazard Hello! Could you test if PR #1137 works well on windows? You can make any path fixes along the way

pUrGe12 avatar Sep 25 '25 18:09 pUrGe12

@pUrGe12 Sure, will do! Thanks for the opportunity.

codeshazard avatar Sep 25 '25 19:09 codeshazard

@pUrGe12 Hi! I tested PR #1137 on Windows 11 as requested. Initially, it didn’t work out-of-the-box — I ran into issues with path handling, language detection, and CLI argument parsing. I made several changes to get it working, including:

  • Refactoring path logic to support Windows-style separators
  • Cleaning up module name formatting and language detection
  • Patching the -v argument to accept verbosity levels After these fixes, the scan completed successfully on Windows. Would it be okay if I open a separate PR to share these changes? It would document the platform-specific adjustments and help improve cross-platform support.

codeshazard avatar Sep 26 '25 21:09 codeshazard

@codeshazard yes, please open a separate PR

securestep9 avatar Sep 27 '25 09:09 securestep9

Hi! I’m new to open source and would like to work on this issue as my first contribution. Could you please assign it to me or guide me on how to start?

vishantgawali1811 avatar Oct 20 '25 19:10 vishantgawali1811

Hi @vishantgawali1811 - this feature is already in active development by @codeshazard I suggest you look at other OWASP Projects in the need of contributions here: https://nest.owasp.org/contribute

securestep9 avatar Oct 21 '25 21:10 securestep9

Hey, I’d like to work on this

Awaneesh03 avatar Nov 03 '25 09:11 Awaneesh03

Hi @securestep9 I just saw this good first issue not answered yet and currently under work is there a way to help or assist to resolve this issue with @codeshazard to resolve it with better efficiency

I look forward to help @codeshazard and resolve this issue

koffandaff avatar Dec 03 '25 14:12 koffandaff