OSVR-Unity-Rendering icon indicating copy to clipboard operation
OSVR-Unity-Rendering copied to clipboard
verified publisher icon OSVR

New data types

Open DuFF14 opened this issue 9 years ago • 2 comments

Changes int to std::uint8_t, although this did not fix the bug/crash we are seeing in Unity (which occurs on some machines more often than others). Caches nonzero viewport values and returns them to Unity when we hit a bug that causes the width and height of viewport to be 0 temporarily. This avoids a crash but does not fix the bug.

DuFF14 avatar Dec 12 '16 19:12 DuFF14

See https://github.com/OSVR/OSVR-Unity/pull/199 I think this is related to: https://github.com/OSVR/OSVR-Unity-Rendering/issues/21

DuFF14 avatar Dec 12 '16 19:12 DuFF14

@rpavlik please test this version of Palace to determine if these changes avoid a crash on your system: https://drive.google.com/open?id=0B0X-T5b2-zcOU3o2Rk5lQjIwUG8 Also let me know if there is a better approach for handling the errors that pop up in GetViewport, GetEyePoses, and GetProjectionMatrix. On Friday, we learned this may be a stack corruption issue, since errors were logged when none of the conditions were met to log the error. That has not been fixed, but we may be able to avoid a crash for now.

DuFF14 avatar Dec 12 '16 19:12 DuFF14