grass-addons icon indicating copy to clipboard operation
grass-addons copied to clipboard

i.superpixel.slic extension not found

Open mkieser opened this issue 4 years ago • 7 comments

Name of the addon i.superpixel.slic

Describe the bug I run the g.extension i.superpixels.slic command and the URL https://github.com/OSGeo/grass-addons/trunk/grass7/imagery/i.superpixels.slic doesn't exist. I've also tried the command with the full URL g.extension i.superpixels.slic url="https://github.com/OSGeo/grass-addons/tree/grass7/src/imagery/i.superpixels.slic" branch="grass7" and the extension is not found.

To Reproduce Steps to reproduce the behavior:

  1. Run g.extension i.superpixels.slic
  2. See erros
  3. Run g.extension i.superpixels.slic url="https://github.com/OSGeo/grass-addons/tree/grass7/src/imagery/i.superpixels.slic" branch="grass7"
  4. See error

Expected behavior I expect that the i.superpixels.slic extension will be added from the GitHub URL

Screenshots N/A

System description (please complete the following information):

  • Operating System: Docker container built from FROM neteler/grassgis7
  • GRASS GIS version
version=8.0.dev
date=2021
revision=exported
build_date=2021-07-08
build_platform=x86_64-pc-linux-gnu
build_off_t_size=8
libgis_revision=2021-07-08T13:50:41+00:00
libgis_date=2021-07-08T13:50:41+00:00
proj=4.9.3
gdal=2.2.3
geos=3.6.2
sqlite=3.22.0

Additional context N/A

mkieser avatar Jul 08 '21 15:07 mkieser

I'm experiencing the same with GRASS 7.8.5 (current stable) and grass dev recompiled as of today too. AFAIU the addon installation is failing since the re-structuring of grass-addons repo in #571 (or at least I cannot find the proper parameter specification to make it work).

But the problem is with g.extension that needs to be fixed accordingly and not the addons themselves. There's a draft PR that tackles this: https://github.com/OSGeo/grass/pull/1700

veroandreo avatar Jul 08 '21 16:07 veroandreo

The problem is probably that grass7 now is the default branch (more than that the grass7 branch got restructured). "trunk" in the URL refers to the default branch.

When the branch concept got included in g.extension, unfortunately, main and master were treated as if they allways would be the default branches, which is what now causes trouble...

Will try to get #1700 ready to merge ASAP...

ninsbl avatar Jul 08 '21 22:07 ninsbl

Hi all, Same problem for me here. Do you know if the issue will be solved in 7.8.5 or I would have to use grass dev and compile myself when the source code will be fixed ? Thanks

tgrippa avatar Jul 12 '21 14:07 tgrippa

Grass 7.8.5 is the current stable and because of addon repo restructuring, g.extension is momentarily not working. It should be solved for 7.8.6, this is a blocker of the release indeed.

veroandreo avatar Jul 12 '21 23:07 veroandreo

Hi all, I have the same problem when trying: g.extension r.forestfrag .

carolxgl avatar Jul 15 '21 16:07 carolxgl

If you are comfortable with JupyterLab you can test OSGeo/grass#1700 using Binder (link). Click File > New > Terminal and type:

grass data/grassdata/nc_basic_spm_grass7/user1
g.extension r.clip

wenzeslaus avatar Jul 20 '21 02:07 wenzeslaus

FYI: https://github.com/OSGeo/grass/pull/1700 has been merged into master.

ninsbl avatar Jul 21 '21 14:07 ninsbl

I think this can be closed as fixed. Can you confirm @mkieser ?

ninsbl avatar Sep 24 '22 20:09 ninsbl