Encore icon indicating copy to clipboard operation
Encore copied to clipboard

Add a "fork me on github" ribbon

Open kaivalyar opened this issue 9 years ago • 7 comments

kaivalyar avatar Jan 27 '17 18:01 kaivalyar

I have submitted a pr - somebody please review ... taken from here: https://simonwhitaker.github.io/github-fork-ribbon-css/

kaivalyar avatar Jan 27 '17 18:01 kaivalyar

@kaivalyar Looks fine. Can you make it black and comment out the underlying button?

0xRampey avatar Jan 29 '17 06:01 0xRampey

#10

0xRampey avatar Jan 29 '17 06:01 0xRampey

@prampey i'm unsure of the encore workflow - how to i see my changes? (I made the previous commit blindly - without actually seeing the effects my code was having)

kaivalyar avatar Jan 29 '17 10:01 kaivalyar

I think that the README.md is enough for installation. Just make sure you have node and npm installed.

SebastinSanty avatar Jan 29 '17 11:01 SebastinSanty

yeah well, but do i need to install it just to fix the ribbon?!

kaivalyar avatar Jan 29 '17 15:01 kaivalyar

Yes you would have to. Would help in further contributions too.

SebastinSanty avatar Jan 29 '17 17:01 SebastinSanty