AMO-Tools-Desktop icon indicating copy to clipboard operation
AMO-Tools-Desktop copied to clipboard

Custom Materials: Lighting Fixtures

Open rmroot opened this issue 6 months ago • 1 comments

Lighting fixtures have been added to the suite: https://github.com/ORNL-AMO/MEASUR-Tools-Suite/issues/15

@koay9f can elaborate but the desire is for lighting fixtures to be treated like other custom materials, where users can create there own. This issue has two parts, possibly three, that can be broken up into different issues.

  1. Migrate the fixtures db to use the suite and remove the current .csv
  2. Add custom fixtures to the custom materials section (probably re-name)
  3. It may be worth giving that whole section a facelift
  • flue gas materials leverage behavior subjects. It may be worth the effort to implement behavior subjects for the other materials as well. Update this issue and create issues as needed.

rmroot avatar Oct 06 '25 16:10 rmroot

@WoodrowKromar I would complete #7742 first for familiarity sake.

I would flip steps 2 and 3. Familiarize yourself with the Custom Materials and where they are used in the app, survey existing related bugs and see if we can tie up existing broken functionality and find an obvious facelift path. Let's meet on what you find before adding the lighting fixtures to the section

nbintertech avatar Oct 24 '25 14:10 nbintertech

Since we're now doing a suite release for other issues, this will need to get done for 1.6.5 - I propose we just drop requirements related to improving the custom materials.

nbintertech avatar Nov 26 '25 15:11 nbintertech