ORNL-AMO
Pump Fixes
Update app-wide validation for pump stages Update pump inventory stages defaults to be 1
Let's walk through when you start
So, you're looking through out the app (pump module, pump inventory, pump calculators) for this field:
It's default value should be 1. The field should like the field there (with the nice buttons).
Validation -
Red: it should be >=1. it should be a whole number.
Yellow: < 15 "Multistage pumps usually have less than 15 impellers. Please check your data."
I think that's it...
@koay9f we could potentially add this same validation (whole number) to PH openings. I assume there are other places in the app also. @WoodrowKromar - NOT required to close this. Can be separate work
@koay9f
5. In Achievable Efficiency there is a side-effect due to the stages being to high. Seems to be anything higher than 9, but this might be contextually dependent on other fields. Address this last.
The issue is that if values are unplottable and go below 0, then it errors. This error banner will display that we cannot plot below 0.
Honestly, I'm getting values below zero before this error appears so I think the validation isn't triggering as early as it "should" given that wording. It seems to be triggering when the efficiency for the points hits below zero. Let's change text to "Efficiency at specified points is below zero, please check data inputs" If this doesn't get done before release, that is fine - the work done so far can stay in, let's just finish up for next release.