orcid-model icon indicating copy to clipboard operation
orcid-model copied to clipboard

Java 17 jakarta compatibility

Open denis-yuen opened this issue 3 years ago • 6 comments

Working on the migration ourselves, noting that this library makes heavy use of javax.xml annotations.

Partial details at https://blogs.oracle.com/javamagazine/post/its-time-to-move-your-applications-to-java-17-heres-why-and-heres-how While at it, I think there a bunch of other dependencies that change due to the jakarta migration. Glancing at https://mvnrepository.com/artifact/org.orcid/orcid-model/3.2.0

A bunch of other dependencies also change due to the whole jakarta migration

javax.annotation/javax.annotation-api -> lakarta.annotation:jakarta.annotation-api io.swagger.core.v3/swagger-jaxrs2 -> io.swagger.core.v3:swagger-jaxrs2-jakarta javax.annotation/javax.annotation-api -> jakarta.annotation:jakarta.annotation-api

denis-yuen avatar May 01 '23 19:05 denis-yuen

May be similar to https://github.com/dockstore/swagger-java-quay-client/pull/6/files for an equivalent migration that we're working on

denis-yuen avatar May 01 '23 19:05 denis-yuen

Hi @denis-yuen! Thanks for your comments, we are planning in moving to Java 17, however, this will not happen until next year, since we will need several other dependencies to be upgraded before and there will be a big refactoring needed to make our app work with the jakarta libraries.

amontenegro avatar May 02 '23 18:05 amontenegro

Any updates on when Java 17 / Jakarta compatibility is coming? This is becoming a major issue for DSpace as we are attempting to move to Java 17 / Jarkarta (https://github.com/DSpace/DSpace/pull/9321), and doing so appears to break all ORCID integrations.

tdonohue avatar Mar 06 '24 22:03 tdonohue

Hmm... It appears there may already be an Jakarta version? I'm not sure where/how this is being maintained, but I just noticed an org.orcid > orcid-model-jakarta Maven artifact in Maven Central: https://mvnrepository.com/artifact/org.orcid/orcid-model-jakarta/3.3.0

tdonohue avatar Mar 07 '24 14:03 tdonohue

That's actually our attempt at updating in the thread linked above. I'm surprised Maven Central picked it up.

I think we were able to run the unit tests, but we're only using it a light way (retrieving author names given an id). You're all welcome to try it and/or use it to speed up the creating an official update.

denis-yuen avatar Mar 07 '24 15:03 denis-yuen

This library is the same one we use to run our backend services and we update it in line with those.

As @amontenegro says, we're at least a year away from Java 17 so it's not going to move to Jakarta for quite some time.

The best way forward is probably to generate your own model using our XML schema.

TomDemeranville avatar Mar 08 '24 11:03 TomDemeranville