OPM
Making BlackOilFluidState GPU friendly
This is in draft at the moment. Essentially this adds decorators to the functions and eventually will add support non-static fluidsystem-objects.
Is there any relation between this work and PR #4427?
Yes, in the sense that the BlackOilFluidState object will eventually use the non-static variant of the BlackOilFluidSystem developed in that pull-request, but this PR will work without 4427 (or at least, that is the goal for now).
I do not at a first glance see any issues with this PR. Decorators introduced, throws use the GPU friendly macro, non-static BOFS is used with appropriate ctor etc.
Looks good to me.
It seems clear that the use of null pointer here is undefined behaviour. I have an idea for a different approach that also may be useful for transforming other parts of the code to be GPU-friendly vs. the fluid system. Will experiment.
It seems clear that the use of null pointer here is undefined behaviour.
Not clear at all, in fact, it is well-defined, but I will change