op-sqlite icon indicating copy to clipboard operation
op-sqlite copied to clipboard

Windows support

Open listepo opened this issue 2 years ago • 8 comments

It would be nice to have support for MacOS and Windows

listepo avatar Jan 24 '24 10:01 listepo

macos is already supported. I don't know how windows modules work, so PRs are welcome

ospfranco avatar Jan 24 '24 11:01 ospfranco

@ospfranco https://github.com/microsoft/react-native-windows-samples/tree/main/samples/NativeModuleSample/cppwinrt Can this example help? Sorry, I don't know C++ well enough

listepo avatar Jan 24 '24 12:01 listepo

No idea buddy. I will probably not do this myself, no free time atm. Somebody else will have to take care of it.

ospfranco avatar Jan 24 '24 12:01 ospfranco

@ospfranco any idea how much work is to add windows support?

maksimlya avatar Jun 03 '24 14:06 maksimlya

Nope, I have never developed for windows

ospfranco avatar Jun 03 '24 14:06 ospfranco

@ospfranco Hi, I can try adding windows support. Can you tell me how you built the jni libs(android), .a files(ios)? I noticed you have 2 versions, I did not find any make files.

maksimlya avatar Jun 27 '24 07:06 maksimlya

Before you start developing this, I hope you realize will have to maintain the Windows versions for ever. The moment I change the API or do some breaking change I will not even try to take a look and try to make it work.

That being said, for any existing library file in the repo. You need to compile it in their source repo and then drop them here. You will probably need to compile crsqlite and libsql. crsqlite I cannot help, I just found some prebuilt binary and dropped it in the repo. For libsql turso paid me for development time to port to mobile platforms. Here are the instructions (link to the PR is inside) on how to compile libsql for mobile targets.

ospfranco avatar Jun 27 '24 07:06 ospfranco