Viewers icon indicating copy to clipboard operation
Viewers copied to clipboard

feat(ViewportActionMenu): Initial WindowLevel per viewport and new patient info

Open IbrahimCSAE opened this issue 2 years ago β€’ 3 comments

Context

Changes & Results

Testing

Checklist

PR

  • [] My Pull Request title is descriptive, accurate and follows the semantic-release format and guidelines.

Code

  • [] My code has been well-documented (function documentation, inline comments, etc.)

Public Documentation Updates

  • [] The documentation page has been updated as necessary for any public API additions or removals.

Tested Environment

  • [] OS:
  • [] Node version:
  • [] Browser:

IbrahimCSAE avatar Feb 28 '24 17:02 IbrahimCSAE

Deploy Preview for ohif-platform-docs canceled.

Name Link
Latest commit 958fdf73153d1863bf29558236c5f82132d360cd
Latest deploy log https://app.netlify.com/sites/ohif-platform-docs/deploys/660c06b66e4b7a0008989179

netlify[bot] avatar Feb 28 '24 17:02 netlify[bot]

Deploy Preview for ohif-dev canceled.

Name Link
Latest commit 958fdf73153d1863bf29558236c5f82132d360cd
Latest deploy log https://app.netlify.com/sites/ohif-dev/deploys/660c06b6f546830009a944d3

netlify[bot] avatar Feb 28 '24 17:02 netlify[bot]

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 44.37%. Comparing base (8a335bd) to head (958fdf7). Report is 272 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3963      +/-   ##
==========================================
- Coverage   46.23%   44.37%   -1.87%     
==========================================
  Files          78       80       +2     
  Lines        1276     1334      +58     
  Branches      312      327      +15     
==========================================
+ Hits          590      592       +2     
- Misses        548      589      +41     
- Partials      138      153      +15     
Files Coverage Ξ”
platform/app/src/appInit.js 0.00% <0.00%> (ΓΈ)

... and 9 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Ξ” = absolute <relative> (impact), ΓΈ = not affected, ? = missing data Powered by Codecov. Last update 07301fc...958fdf7. Read the comment docs.

codecov[bot] avatar Feb 28 '24 18:02 codecov[bot]

@sedghi

Fixed

  • Colorbar sticking around for new displaysets
  • OHIF logo position
  • Viewport overlay no longer selectable, Viewport Markers no longer selectable
  • Removed PET colormap tool in TMTV
  • Removed WindowLevel presets in all modes
  • Fixed colorbar position in TMV mode
  • Fixed study date not showing up in MPR
  • inverted icon for window level menu on inverted displaysets
  • black markers for colorbar on inverted displaysets

Comments

  • For PT window level, it seems the problem is the preset, it puts them in a level where window tool can't control them anymore, u can verify this if you switch back to default preset (first item in list), the window tool will start working again, tell me what u want to do for this
  • we should not show I: for the reconstructed views since they are not instance number: I cant find a good way to do this, suggestions?

image

I don't understand what needs to be fixed?

  • I noticed something has broken the colormap sync again recently in OHIF, it affected this PR as well

https://viewer-dev.ohif.org/tmtv?StudyInstanceUIDs=1.3.6.1.4.1.14519.5.2.1.7009.2403.871108593056125491804754960339

Change the colormap using the tool, then go into 1x1 and comeback out, the sync is broken...

This affected my MPR as well when you change the colormap in none MPR then go into MPR, it goes back to grayscale, it wasn't like this before

IbrahimCSAE avatar Mar 28 '24 07:03 IbrahimCSAE

1 failed test on run #3785 β†—οΈŽ

1 42 0 0 Flakiness 0

Details:

Add react-i18next for internationalization support
Project: Viewers Commit: 958fdf7315
Status: Failed Duration: 05:57 πŸ’‘
Started: Apr 2, 2024 1:33 PM Ended: Apr 2, 2024 1:39 PM
FailedΒ  cypress/integration/customization/HangingProtocol.spec.js β€’ 1 failed test

View Output Video

Test Artifacts
OHIF HP > Should navigate next/previous stage Test Replay Screenshots Video

Review all test suite changes for PR #3963 β†—οΈŽ

cypress[bot] avatar Mar 29 '24 18:03 cypress[bot]