CommonDataModel icon indicating copy to clipboard operation
CommonDataModel copied to clipboard

Drop table COHORT_DEFINITION

Open cgreich opened this issue 11 months ago • 3 comments

This table was contrived as a way to define the content of a cohort. That was before ATLAS. There is no need anymore, as we have a different mechanism to achieve that goal.

cgreich avatar Feb 14 '25 19:02 cgreich

Some of us use this table because due to the limitations of Atlas. We create cohorts outside of Atlas and import them into the CDM during our ETL. Since it is being used by the community, we shouldn’t deprecate the table.

MelaniePhilofsky avatar Feb 18 '25 13:02 MelaniePhilofsky

Want to shift it to CDM Expansion? Since there is no generally used purpose or definition?

cgreich avatar Feb 18 '25 15:02 cgreich

Possibly. BUT first we need to discuss and document what support the Expansion tables in the CDM receive. Do they have DDLs? Are there DQD checks for them? What about Atlas and other analytical tool support?

Once we decide on the requirements for Canonical vs Expansion, then we can review all current and proposed CDM tables and put them into a bucket. Also, we might need another level or designation for CDM tables. Canonical is the core CDM; Expansion is supported with DDLs, rules & requirements and Themis conventions; and then there are "other" tables which are more sandbox or experimental tables, which could be upgraded to Expansion or Canonical tables, but need more work. This is just an idea, but we need to start with the requirements for the Canonical CDM before adding or dropping any tables.

MelaniePhilofsky avatar Feb 18 '25 16:02 MelaniePhilofsky