oggm icon indicating copy to clipboard operation
oggm copied to clipboard

added option to use gridded 2D topo data for geodetic_mb_calibration

Open afisc opened this issue 1 year ago • 1 comments

Until now the function massbalance.mb_calibration_from_geodetic_mb() did use the height/elevation data of a glaciers flowline(s) to calibrate the massbalance parameters. This is now also possible by using gridded/distributed data via the additional boolean argument mb_2d, which is useful for the usage of distributed models like IGM.

  • [ ] Tests added/passed (will still be added next week)
  • [ ] Fully documented
  • [ ] Entry in whats-new.rst

afisc avatar May 29 '24 21:05 afisc

Hello @afisc! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 1714:100: E501 line too long (106 > 99 characters)

Comment last updated at 2024-06-18 13:50:31 UTC

pep8speaks avatar May 29 '24 21:05 pep8speaks

added a test case which compares the calibrated 'melt_f' (Melt Factor) for the 1D(flowline) and 2D(gridded_data) calibration method

afisc avatar Jun 04 '24 12:06 afisc